Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Locator - allow filter by LocationCategory #67

Merged
merged 3 commits into from
Apr 7, 2016

Conversation

jsirish
Copy link
Member

@jsirish jsirish commented Nov 10, 2015

In CMS Settings tab on Locator page, added following:

has_one LocationCategory

If a user selects a category, list is filtered by that category on load, and category drop down is removed from the search form.

Allows module to have multiple Locator pages in a site and show different locations on each.

fixes #57

@jsirish
Copy link
Member Author

jsirish commented Nov 10, 2015

should merge #64 first, then rebase

@jsirish jsirish force-pushed the feature/categoryFilter branch from b1a642e to 8bc6097 Compare December 18, 2015 20:55
@jsirish jsirish force-pushed the feature/categoryFilter branch from 8bc6097 to 327be57 Compare December 26, 2015 23:03
@jsirish
Copy link
Member Author

jsirish commented Dec 26, 2015

reworked this for many_many Categories

@jsirish jsirish force-pushed the feature/categoryFilter branch 2 times, most recently from 99c427e to 9b109bd Compare March 16, 2016 01:53
@codecov-io
Copy link

Current coverage is 61.36%

Merging #67 into master will increase coverage by +1.99% as of 6f7ea07

@@            master     #67   diff @@
======================================
  Files            2       2       
  Stmts          160     176    +16
  Branches         0       0       
  Methods         18      19     +1
======================================
+ Hit             95     108    +13
  Partial          0       0       
- Missed          65      68     +3

Review entire Coverage Diff as of 6f7ea07

Powered by Codecov. Updated on successful CI builds.

@jsirish jsirish force-pushed the feature/categoryFilter branch from 9b109bd to c224dbf Compare April 7, 2016 19:32
In CMS Settings tab on Locator page, added following:

many_many LocationCategory

If a user selects one or more categories, list is filtered by those categories on load, and category drop down is removed.

Allows module to have multiple Locator pages in a site and show different locations on each.

fixes dynamic#57
@jsirish jsirish force-pushed the feature/categoryFilter branch from c224dbf to f39fcf3 Compare April 7, 2016 20:00
@jsirish jsirish merged commit 29ed756 into dynamic:master Apr 7, 2016
@jsirish jsirish deleted the feature/categoryFilter branch February 11, 2017 02:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Locator page - allow multiple Locators on site, show different locations
2 participants